Skip to content

Test rhp's charts as a caller meets them - #13

Merged
zaiev merged 3 commits into
mainfrom
test-rhps-charts-as-a-caller-meets-them
Nov 16, 2026
Merged

zaiev merged 3 commits into
mainfrom
test-rhps-charts-as-a-caller-meets-them

Conversation

@zaiev

@zaiev zaiev commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Why

rhp's charts lost their tests when the twins that compared only the templates Solid's compiler made of them went (#5): since then nothing ran a chart in a browser but the one the hydration tests prerender, so a scale's ticks and a changed row's redraw were held by no test, and the vault could not name a proof of either at a release.

Changes

  • rhp's charts are tested as a caller meets them, in OCaml: each row plotted by its slat, the chart scaled to its range with a tick at each step, and a row whose field changes redrawn in place on the next frame, the others untouched.
  • No release of its own: tests change nothing a user installs, so they land with the next release's change.

Verified

  • make test: vitest's 968, the three new among them; make lint; make docs with no warning.
  • The redraw test fails as a redraw that does not happen: read before the frame rhp draws on, the changed row's bar still holds its old value.

rhp's charts lost their tests when the twins that compared only the
templates Solid's compiler made of them went: since then nothing ran a
chart in a browser but the one the hydration tests prerender, so a
scale's ticks and a changed row's redraw were not held by any test, and
the vault could not name a proof of either at a release.

Each is now tested as a caller meets it, in OCaml, against what rhp
draws: the rows plotted by their slat, the chart's range and its ticks,
and a row whose field changes redrawn in place on the next frame, the
others untouched.
A test that runs only in this repository changes nothing a user installs,
so it names no version: the charts' tests land with the next release's
change, not as one of their own.
The page's install line named 0.11.1, whose asset no release has made.
@zaiev
zaiev merged commit c06cb3a into main Nov 16, 2026
2 checks passed
@zaiev
zaiev deleted the test-rhps-charts-as-a-caller-meets-them branch November 16, 2026 18:08
zaiev added a commit that referenced this pull request Nov 16, 2026
Nothing ran litany on solidtype, and its first run reported a literal condition at every component tag: the `if false` that holds a tag's props to `Props.check` was written at the tag's own location, so any linter reading the typed tree took it for the user's code. An application on Hypha Stack, whose rules gate runs litany, could not pass with a single component on its page: HAF's MVP run stopped there. This PR completes 0.11.1, beside its change, with #13's tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant